Wireshark-commits: [Wireshark-commits] master-3.2 c5554d1: Qt: Fix import profile from directory cr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 01 Mar 2020 11:41:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5554d1e9fe757f6faaac1f85680324dc38fbb35
Submitter: "Tomasz Moń <desowin@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

c5554d1 by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Fix import profile from directory crash
    
    Do not append separator to import directory path. Calling QFileInfo()
    constructor with string ending in directory separator results in
    creating QFileInfo instance for file with empty filename.
    
    Bug: 16410
    Change-Id: I4fe248fcdb0c0c67843652475ae58c2a473a9fa8
    Reviewed-on: https://code.wireshark.org/review/36238
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 04a86e99e46d680a50e78340ea6c7d16349f370a)
    Reviewed-on: https://code.wireshark.org/review/36251
    Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
    

Actions performed:

    from  58e92b6a  Qt: Fix profile zip import on Windows
     add  c5554d1   Qt: Fix import profile from directory crash


Summary of changes:
 ui/qt/profile_dialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)