Wireshark-commits: [Wireshark-commits] master b1a4aac: Qt: fix packet list selection regression
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 27 Feb 2020 10:52:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b1a4aac54323304b489af3282e7ce5fc4512cf37
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b1a4aac by Rasmus Jonsson (wasmus@xxxxxx):

    Qt: fix packet list selection regression
    
    When adding or removing a filter, the currently selected packet
    is deselected. beginResetModel/ endResetModel were used which
    reset the QModelIndex, now changed back to dataChanged/
    headerDataChanged as before.
    
    Bug: 16414
    Change-Id: Ia8fa91e3378bdc0792382184e75e59900397e8b9
    Reviewed-on: https://code.wireshark.org/review/36204
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  1ed9ddd   Fix some typoes in comments.
     add  b1a4aac   Qt: fix packet list selection regression


Summary of changes:
 ui/qt/models/packet_list_model.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)