Wireshark-commits: [Wireshark-commits] master 7b99a82: Edit Resolved Name: Don't add duplicate IPs
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 24 Feb 2020 07:45:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7b99a82bf893f51741853fd3332c9ddc4cf7df42
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7b99a82 by Dylan Ulis (daulis0@xxxxxxxxx):

    Edit Resolved Name: Don't add duplicate IPs
    
    1. Switch list of manually resolved names from a list to a map
       (IP Address --> Custom Hostname)
    2. If an address was already in the list, just update the old entry.
    Previously this added a new entry anytime somebody would edit a
    hostname.
    3. Display the previous hostname in the GUI
    4. Remove unused manually_resolve_cleanup()
    
    Bug: 11221
    Change-Id: I42d5b6267eb6613bdf7783865bc2d30d6bda1147
    Reviewed-on: https://code.wireshark.org/review/36059
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2c4fc32   smpp: Set the column fence before dissecting the PDU
     add  7b99a82   Edit Resolved Name: Don't add duplicate IPs


Summary of changes:
 debian/libwireshark0.symbols   |   2 +-
 epan/addr_resolv.c             | 110 +++++++++++++++++++++++------------------
 epan/addr_resolv.h             |  10 ++--
 ui/qt/address_editor_frame.cpp |  17 +++++++
 ui/qt/address_editor_frame.h   |   1 +
 5 files changed, 87 insertions(+), 53 deletions(-)