Wireshark-commits: [Wireshark-commits] master d400dbe: Qt: Remove unnecessary processEvents() call
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Feb 2020 13:51:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d400dbe476bdc04f3656869bdb46304092e79b6f
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d400dbe by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Remove unnecessary processEvents() call
    
    MainWindow::captureFileReadStarted() is called inside event handlers.
    There isn't any actual processing after the captureFileReadStarted() is
    called so in most cases the code will quickly return to the event loop.
    In case of cf_read() callbacks, there is dedicated "slow processing"
    detection implemented that eventually leads to processEvent() call in
    update_progress_dlg().
    
    Change-Id: Icfefa0ba7bf1bec43014e30756d0eec4078d389c
    Reviewed-on: https://code.wireshark.org/review/36113
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  7e02165   More issues spotted by PVS-Studio in bug 16335.
     add  d400dbe   Qt: Remove unnecessary processEvents() call


Summary of changes:
 ui/qt/main_window_slots.cpp | 2 --
 1 file changed, 2 deletions(-)