Wireshark-commits: [Wireshark-commits] master 2c1d660: Qt: Access I/O Graph settings via UAT interf
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Feb 2020 11:08:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2c1d660940f04aa44e5966418e7e828d790d3a5a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2c1d660 by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Access I/O Graph settings via UAT interface
    
    All I/O Graph instances share the same configuration. The code was
    accessing the UAT underlying number of items variable (num_io_graphs_)
    directly but the actual rows were accessed indirectly via UAT interface.
    This could lead to UAT missynchronization and in turn an out of range
    index access in IOGraphDialog::createIOGraph().
    
    Fix the issue by not using the num_io_graphs_ directly.
    
    Bug: 16373
    Change-Id: Ifbc0fddb619d23f31f32aa46c4ae613954a8b780
    Reviewed-on: https://code.wireshark.org/review/36106
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e30f0d0   Some issues spotted by PVS-Studio in bug 16335.  Many more remain
     add  2c1d660   Qt: Access I/O Graph settings via UAT interface


Summary of changes:
 ui/qt/io_graph_dialog.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)