Wireshark-commits: [Wireshark-commits] master 80e1c54: CANopen: Add SDO Block Upload/Download decod
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 07 Feb 2020 04:39:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=80e1c54ff45ded2db6c90bac412b73641bd06553
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

80e1c54 by Adrien Aubry (adraub@xxxxxxxxx):

    CANopen: Add SDO Block Upload/Download decoding
    
    Previous code did not properly decode protocol (Object dictionnary is not always sent). All changes comply with CANopen DS301 freely available on the web.
    
    Change-Id: Ibaae09af0f1a5300a323a9c94077d1fb7dadd560
    Reviewed-on: https://code.wireshark.org/review/35558
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9266a27   macOS: Remove a version check from osx-app.sh.
     add  80e1c54   CANopen: Add SDO Block Upload/Download decoding


Summary of changes:
 epan/dissectors/packet-canopen.c | 359 ++++++++++++++++++++++++++++++++-------
 1 file changed, 294 insertions(+), 65 deletions(-)