Wireshark-commits: [Wireshark-commits] master 281edac: TLS: do not dissect OCSP when disabled
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 31 Jan 2020 08:52:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=281edac5c0c9871060f3f04f735a7c1a908a9d50
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

281edac by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS: do not dissect OCSP when disabled
    
    The go test suite for crypto/tls produces a status_request extension
    with "dummy ocsp" as extension data. That triggers a Malformed Packet
    exception and breaks dissection of the following data.
    
    Fix this by skipping OCSP dissection when disabled.
    
    Change-Id: I9deb4385862503656e6ff316b36c2b55e6903279
    Reviewed-on: https://code.wireshark.org/review/35989
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  d3c704c   TFTP: Redesign conversation creation algorithm
     add  281edac   TLS: do not dissect OCSP when disabled


Summary of changes:
 epan/dissectors/packet-tls-utils.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)