Wireshark-commits: [Wireshark-commits] master-3.0 ced4fe3: RTP: Fix rtpdump export
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 30 Jan 2020 09:20:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ced4fe3b8ccf8f99dce48285234abb18aa4d26af
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

ced4fe3 by Orgad Shaneh (orgad.shaneh@xxxxxxxxxxxxxx):

    RTP: Fix rtpdump export
    
    Broke by 87973bf516432756f6948e969dbe9d6aa8a27017.
    
    RtpStreamDialog allocates its own rtpstream_info_t, and copies the original stream's info.
    
    Then RtpStreamDialog::on_actionExportAsRtpDump_triggered calls
    rtpstream_save with this copy.
    
    On save, reset_tap_listeners is called, and it clears all the tree items,
    destroying the allocated copy *before* it is used for the actual export.
    
    Trace:
    1   rtpstream_info_free_all                             tap-rtp-common.c       104
    2   RtpStreamTreeWidgetItem::~RtpStreamTreeWidgetItem   rtp_stream_dialog.cpp  85
    3   RtpStreamTreeWidgetItem::~RtpStreamTreeWidgetItem   rtp_stream_dialog.cpp  86
    4   QTreeModel::clear()
    5   RtpStreamDialog::tapReset                           rtp_stream_dialog.cpp  309
    6   rtpstream_reset_cb                                  tap-rtp-common.c       172
    7   reset_tap_listeners                                 tap.c                  418
    8   cf_retap_packets                                    file.c                 2243
    9   rtpstream_save                                      rtp_stream.c           97
    10  RtpStreamDialog::on_actionExportAsRtpDump_triggered rtp_stream_dialog.cpp  515
    
    Bug: 16351
    Change-Id: I54d37a2c97997395936df94ee5481b0d6d198aed
    Reviewed-on: https://code.wireshark.org/review/35979
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit eb0dcc984f49e58bad3312290b1ee965097bc222)
    Reviewed-on: https://code.wireshark.org/review/35988
    

Actions performed:

    from  6d84d87   Fix indentation.
     add  ced4fe3   RTP: Fix rtpdump export


Summary of changes:
 ui/qt/rtp_stream_dialog.cpp | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)