Wireshark-commits: [Wireshark-commits] master 8efde39: extcap: terminate the child process using ki
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 29 Jan 2020 15:52:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8efde3980524daf84405d5778872503ea4f6c9cf
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8efde39 by Anders Esbensen (Anders.Esbensen@xxxxxxxxxx):

    extcap: terminate the child process using kill.
    
    On linux and osx extcap would potentially leave
    the external dumper process running after stopping the capture.
    With this change the child process will receive a TERM signal
    when the capture stops.
    
    Change-Id: I2681a26509c90696c98c7615fbab172604ce6e31
    Reviewed-on: https://code.wireshark.org/review/35959
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e0ca87c   tls: update list of known CT logs to 2019-12-23
     add  8efde39   extcap: terminate the child process using kill.


Summary of changes:
 extcap.c | 4 ++++
 1 file changed, 4 insertions(+)