Wireshark-commits: [Wireshark-commits] master-2.6 28dc014: rdm: Remove incorrect dissection of ack
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Jan 2020 14:48:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=28dc014dc290849ad59ba848f0ce9a355bfb899c
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

28dc014 by Erwin Rol (erwin@xxxxxxxxxxxx):

    rdm: Remove incorrect dissection of ack overflow data
    
    Ack overflow data was incorrectly dissected causing checksum errors. For now
    just display raw data.
    
    Change-Id: Icdd858bdbeeb4dd40e48c45fc46e5e188d53be69
    Signed-off-by: Erwin Rol <erwin@xxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/35915
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    (cherry picked from commit 4f462bb6e3470ccb09b8da1efd4f133169aef03d)
    Reviewed-on: https://code.wireshark.org/review/35945
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  80504ef   artnet: Fix ArtPollReply universe calculation
     add  28dc014   rdm: Remove incorrect dissection of ack overflow data


Summary of changes:
 epan/dissectors/packet-rdm.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)