Wireshark · Wireshark-commits: [Wireshark-commits] master fde8f71: androiddump: Provide fifo argument to g_warning()

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fde8f715ed36c3984fdd04ba13219feb2f682292
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

fde8f71 by Jeroen Roovers (jer@xxxxxxxxxx):

    androiddump: Provide fifo argument to g_warning()
    
    When EXTCAP_ANDROIDDUMP_LIBPCAP=1, the compiler warns:
    
    In file included from /usr/include/glib-2.0/glib.h:62:0,
                     from extcap-base.h:29,
                     from androiddump.c:26:
    androiddump.c: In function ‘extcap_dumper_open’:
    androiddump.c:366:19: warning: format ‘%s’ expects a matching ‘char *’
    argument [-Wformat=]
             g_warning("Can't open %s for saving packets: %s",
    pcap_geterr(pcap));
    (et cetera)
    
    Fix three occurrences of that warning by using char *fifo as it was
    apparently intended.
    
    Fixes: 67a5d9bebebe1bbe668d8da11601c1833bc7bf4d
    Change-Id: I0597a345d87594cbe548d118a57e3751d0e3abf6
    Reviewed-on: https://code.wireshark.org/review/35853
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  380282d   MMSE: add a missing "Ok" value for X-Mms-Retrieve-Status field
     add  fde8f71   androiddump: Provide fifo argument to g_warning()


Summary of changes:
 extcap/androiddump.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)