Wireshark · Wireshark-commits: [Wireshark-commits] master 4ee88f3: netlink: use indicated encoding for attributes

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4ee88f3e34828d8a6ba472b6c6208b5bae2426d0
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4ee88f3 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    netlink: use indicated encoding for attributes
    
    In netlink the general format of attributes includes a network byte order
    indication flag in the header. When set this has to be passed to the
    attribute value dissector function as the byte ordering fo the attribute
    value. Otherwise the heuristically determined capture host byte order has
    to be passed to the attribute value dissector function.
    With the removal of all copies of 'encoding' this can now be achieved
    through setting of the encoding in nl_data.
    
    Change-Id: Iec0c1b2c2958734a469ff6f75db4626846cb30c9
    Reviewed-on: https://code.wireshark.org/review/35831
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  3e072f1   lapdm(.h): fix duplicate include guard (found by lgtm.com)
     add  4ee88f3   netlink: use indicated encoding for attributes


Summary of changes:
 epan/dissectors/packet-netlink.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)