Wireshark-commits: [Wireshark-commits] master 116d381: wiretap: Fix mp4.c compilation.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 Jan 2020 22:24:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=116d381ea4f77f4aa4091289aad0754a21aab214
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

116d381 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    wiretap: Fix mp4.c compilation.
    
    Include string.h as suggested by clang:
    
    ../wiretap/mp4.c:33:4: error: implicitly declaring library function 'memcmp' with type 'int (const void *, const void *, unsigned long)' [-Werror,-Wimplicit-function-declaration]
                            memcmp(magic_buf + 4, mp4_magic, sizeof (mp4_magic)))
                            ^
    ../wiretap/mp4.c:33:4: note: include the header <string.h> or explicitly provide a declaration for 'memcmp'
    
    Change-Id: I2369ad140f95ca10f22c176b9e2646950b1a8f65
    Reviewed-on: https://code.wireshark.org/review/35814
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  62276f7   TPNCP: Avoid multiple registration of preferences
     add  116d381   wiretap: Fix mp4.c compilation.


Summary of changes:
 wiretap/mp4.c | 2 ++
 1 file changed, 2 insertions(+)