Wireshark-commits: [Wireshark-commits] master-3.0 ccfdb54: Qt: Make sure shortcuts are visible in c
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Jan 2020 18:59:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ccfdb54584d6d630c7079eb50c6b6375900c4089
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

ccfdb54 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Make sure shortcuts are visible in context menus.
    
    As of Qt 5.10, context menu shortcuts can be hidden:
    
    https://bugreports.qt.io/browse/QTBUG-61181
    
    Add set_action_shortcuts_visible_in_context_menu to qt_ui_utils and call
    it for our context menus as needed. For Qt 5.{10,11,12} it calls
    QAction::setShortcutVisibleInContextMenu(true).
    
    For Qt 5.13 and later, call
    QStyleHints::setShowShortcutsInContextMenus(true) in
    WiresharkApplication.
    
    Change-Id: Ie8941951c3a9801b4642f4ce15ac217e37d1300f
    Reviewed-on: https://code.wireshark.org/review/35761
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 48024b102de18305c860aa558229fa08ac2709b2)
    Reviewed-on: https://code.wireshark.org/review/35779
    

Actions performed:

    from  616cc51   Point to a page that might be less likely to move.
     add  ccfdb54   Qt: Make sure shortcuts are visible in context menus.


Summary of changes:
 ui/qt/iax2_analysis_dialog.cpp  |  2 ++
 ui/qt/io_graph_dialog.cpp       |  1 +
 ui/qt/lte_rlc_graph_dialog.cpp  |  1 +
 ui/qt/rtp_analysis_dialog.cpp   |  2 ++
 ui/qt/rtp_player_dialog.cpp     |  1 +
 ui/qt/rtp_stream_dialog.cpp     |  2 ++
 ui/qt/sequence_dialog.cpp       |  1 +
 ui/qt/tcp_stream_dialog.cpp     |  1 +
 ui/qt/utils/qt_ui_utils.cpp     | 13 +++++++++++++
 ui/qt/utils/qt_ui_utils.h       |  8 ++++++++
 ui/qt/wireshark_application.cpp |  9 +++++++++
 11 files changed, 41 insertions(+)