Wireshark-commits: [Wireshark-commits] master-3.2 4a62b5e: Qt: Don't plot zero values in I/O scatte
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4a62b5e00656bdecbeb2dafac48046365a05f5a2
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark
Commits:
4a62b5e by Gerald Combs (gerald@xxxxxxxxxxxxx):
Qt: Don't plot zero values in I/O scatter plots
We don't currently distinguish between missing and zero values in I/O
graphs. This can be problematic in scatter plots since the plot points
tend to show up as chartjunk which overwhelms the X axis. In plain,
non-calculated plots assume that zero values mean "missing" and omit
those points.
Describe this in the User's Guide, but comment the text out for now
pending a full update to the I/O Graph section.
Switch to title case in our default graphs. Make the TCP Errors graph
red by default.
Change-Id: I92dcbf05f58ae0b7b7734fa8dfc342424bbea114
Reviewed-on: https://code.wireshark.org/review/35645
Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit 6785c9ad042fbfa75281bfb9eb7306fd9bb697e9)
Reviewed-on: https://code.wireshark.org/review/35744
Actions performed:
from 12b2794 DOIP: Trivial typo fixed
add 4a62b5e Qt: Don't plot zero values in I/O scatter plots
Summary of changes:
docbook/wsug_src/WSUG_chapter_statistics.adoc | 11 +++++++++++
ui/qt/io_graph_dialog.cpp | 24 ++++++++++++++++++------
ui/qt/io_graph_dialog.h | 2 +-
3 files changed, 30 insertions(+), 7 deletions(-)