Wireshark-commits: [Wireshark-commits] master 0db890b: Netlink: Properly interpret and mask out att
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 Jan 2020 04:53:26 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0db890ba59b713e9fd362cb898eac154f1949a11
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

0db890b by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Netlink: Properly interpret and mask out attribute type
    
    The netlink attribute type is a 16 bit field, of which the two top most
    bits are booleans. Interpret them as such.
    The remaining 14 bits form the attribute type value. Due to the flexible
    way the interpretation is setup, through the use of family specific code,
    the header field for the attribute type value has to have a proper mask.
    Otherwise the two top bits are taken (incorrectly) as part of the value.
    Since this may not be obvious to the netlink family dissector creator
    better enforce it by adding the masked value in the underlying netlink
    dissector, using whatever header field is given for this.
    
    Change-Id: I791f9b1de01505d4a4793abbcf62e596b864e2f0
    Reviewed-on: https://code.wireshark.org/review/35725
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c227279   packet-kerberos: try to fix the build on macOS 10.14
     add  0db890b   Netlink: Properly interpret and mask out attribute type


Summary of changes:
 epan/dissectors/packet-netlink.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)