Wireshark-commits: [Wireshark-commits] master ed81b83: packet-kerberos: re-add dissection of ntstat
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 09 Jan 2020 07:12:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ed81b83768306b6517dd7d3bcc680f9f04251543
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ed81b83 by Stefan Metzmacher (metze@xxxxxxxxx):

    packet-kerberos: re-add dissection of ntstatus (KERB_EXT_ERROR) in PA-PW-SALT
    
    We autodetect the length a 12 bytes and the 0 (4 bytes) and 1 (4 bytes)
    values after the 4 bytes NTSTATUS field.
    
    See [MS-KILE] 2.2.1 KERB-EXT-ERROR.
    
    Change-Id: I19345cb3f9c863e54a8f16002987912487f7d76a
    Signed-off-by: Stefan Metzmacher <metze@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/35694
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f9c2b3a   NSIS: Fix a dangling output path.
     add  ed81b83   packet-kerberos: re-add dissection of ntstatus (KERB_EXT_ERROR) in PA-PW-SALT


Summary of changes:
 epan/dissectors/asn1/kerberos/kerberos.cnf         |  12 +-
 .../asn1/kerberos/packet-kerberos-template.c       |  75 +++++++++-
 epan/dissectors/packet-kerberos.c                  | 163 ++++++++++++++-------
 3 files changed, 188 insertions(+), 62 deletions(-)