Wireshark · Wireshark-commits: [Wireshark-commits] master 6785c9a: Qt: Don't plot zero values in I/O scatter plots

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6785c9ad042fbfa75281bfb9eb7306fd9bb697e9
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6785c9a by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Don't plot zero values in I/O scatter plots
    
    We don't currently distinguish between missing and zero values in I/O
    graphs. This can be problematic in scatter plots since the plot points
    tend to show up as chartjunk which overwhelms the X axis. In plain,
    non-calculated plots assume that zero values mean "missing" and omit
    those points.
    
    Describe this in the User's Guide, but comment the text out for now
    pending a full update to the I/O Graph section.
    
    Switch to title case in our default graphs. Make the TCP Errors graph
    red by default.
    
    Change-Id: I92dcbf05f58ae0b7b7734fa8dfc342424bbea114
    Reviewed-on: https://code.wireshark.org/review/35645
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  06bff9f   packet-smb2: handle SMB2_CHANNEL_RDMA_V1_INVALIDATE for read
     add  6785c9a   Qt: Don't plot zero values in I/O scatter plots


Summary of changes:
 docbook/wsug_src/WSUG_chapter_statistics.adoc | 11 +++++++++++
 ui/qt/io_graph_dialog.cpp                     | 24 ++++++++++++++++++------
 ui/qt/io_graph_dialog.h                       |  2 +-
 3 files changed, 30 insertions(+), 7 deletions(-)