Wireshark-commits: [Wireshark-commits] master 7a09c78: NSIS: Don't package .pdb files.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 06 Jan 2020 19:50:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a09c78f123b5dd1237000726f19e2801edeaf39
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7a09c78 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    NSIS: Don't package .pdb files.
    
    We run `windeployqt ... --pdbs` at build time, which means that we need
    to be careful not to include them in the NSIS package. Switch from using
    wildcards ("File ...\*") to using separate "File" commands for each file.
    
    Simplify the PDB Zip package command while we're here.
    
    Bug: 16307
    Change-Id: Ibd9bcbdfdc216f1f6a067baf711bbc184845143f
    Reviewed-on: https://code.wireshark.org/review/35670
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  05d772c   USB MSC: Dissect subclass and protocol codes
     add  7a09c78   NSIS: Don't package .pdb files.


Summary of changes:
 CMakeLists.txt                         |  6 ++----
 packaging/nsis/CMakeLists.txt          |  1 +
 packaging/nsis/windeployqt-to-nsis.ps1 | 21 ++++++++++-----------
 packaging/wix/CMakeLists.txt           |  1 +
 packaging/wix/windeployqt-to-wix.ps1   |  3 +++
 5 files changed, 17 insertions(+), 15 deletions(-)