Wireshark · Wireshark-commits: [Wireshark-commits] master 17cd230: voip_calls_dialog: avoiding of 'remove_tap_listener(): no listen

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=17cd230a03da48667372b758a71534b9508bfa0d
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

17cd230 by Jirka Novak (j.novak@xxxxxxxxxxxx):

    voip_calls_dialog: avoiding of 'remove_tap_listener(): no listener ...' warning
    
    When voip_calls_dialog is opened and then closed, mentioned warning is shown
    because voip_calls_remove_all_tap_listeners is called twice in two different
    methods. Removing of the call from one of method is not possible therefore
    I introduced variable which tracks whether voip_calls_remove_all_tap_listeners
    was already called or not.
    
    Change-Id: Ic3c206cb7baf6612958d383880af296af019ffd8
    Reviewed-on: https://code.wireshark.org/review/35660
    Petri-Dish: Jim Young <jim.young.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jim Young <jim.young.ws@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  376d877   IPv4: Fix incorrect expert info for IGMP TTL
     add  17cd230   voip_calls_dialog: avoiding of 'remove_tap_listener(): no listener ...' warning


Summary of changes:
 ui/qt/voip_calls_dialog.cpp | 18 ++++++++++++++----
 ui/qt/voip_calls_dialog.h   |  1 +
 2 files changed, 15 insertions(+), 4 deletions(-)