Wireshark-commits: [Wireshark-commits] master-3.2 93fe231: packet-iec104: Use pinfo->match_uint ins
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 03 Jan 2020 13:56:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=93fe23171829ae5328c101ce4fe3f97ede293b30
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

93fe231 by Jiří Engelthaler (EngyCZ@xxxxxxxxx):

    packet-iec104: Use pinfo->match_uint instead of port number from configuration
    
    Dissector port number is used to determine the direction.
    It will not work with Decode As when port number from the configuration
    is used. It is better to use the actual dissector port from pinfo->match_uint.
    
    Change-Id: I156728a66ed0cf0fe536da8d9ae958c8c4e0b361
    Reviewed-on: https://code.wireshark.org/review/35632
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 76dfe6004b7cc7e0c90b962a74cdc180bb0b4c7f)
    Reviewed-on: https://code.wireshark.org/review/35633
    

Actions performed:

    from  ddd19ee   tipc: check message bundle size before using it.
     add  93fe231   packet-iec104: Use pinfo->match_uint instead of port number from configuration


Summary of changes:
 epan/dissectors/packet-iec104.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)