Wireshark-commits: [Wireshark-commits] master 83fdea9: GSM RLC/MAC: dissect Mobile Identity in Pack
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 03 Jan 2020 06:26:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=83fdea9ad6890b2f730e28565eb12c9207d39397
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

83fdea9 by Vadim Yanitskiy (axilirator@xxxxxxxxx):

    GSM RLC/MAC: dissect Mobile Identity in Packet Paging Request
    
    Before this patch, Mobile Identity was displayed as an array:
    
    PACKET_PAGING_REQUEST (34) (downlink)
      1000 10.. = MESSAGE_TYPE (DL): PACKET_PAGING_REQUEST (34)
      .... ..00 = PAGE_MODE: Normal Paging (0)
      0... .... = Exist_PERSISTENCE_LEVEL: 0
      .0.. .... = Exist_NLN: 0
      ..1. .... = Repeated_Page_info Exist: 1
      Repeated_Page_info
        ...1 .... = Repeated_Page_info:  (Union)
        u.Page_req_RR
          .... 1... = Page_request_for_RR_conn:  (Union)
          u.Mobile_Identity
            .... .100  0... .... = Length_of_Mobile_Identity_contents: 8
            .001 0100  1... .... = Mobile_Identity_contents: 41
            .001 0011  0... .... = Mobile_Identity_contents: 38
            .001 0010  0... .... = Mobile_Identity_contents: 36
            .000 0000  0... .... = Mobile_Identity_contents: 0
            .000 0000  0... .... = Mobile_Identity_contents: 0
            .000 0000  0... .... = Mobile_Identity_contents: 0
            .000 0000  0... .... = Mobile_Identity_contents: 0
            .001 0010  0... .... = Mobile_Identity_contents: 36
          .00. .... = CHANNEL_NEEDED: 0
          ...0 .... = Exist_eMLPP_PRIORITY: 0
    
    after this patch:
    
          u.Mobile_Identity
            .... .100  0... .... = Length_of_Mobile_Identity_contents: 8
            0010 .... = Identity Digit 1: 2
            .... 1... = Odd/even indication: Odd number of identity digits
            .... .001 = Mobile Identity Type: IMSI (1)
            IMSI: 262420000000042
            [Association IMSI: 262420000000042]
                Mobile Country Code (MCC): Germany (262)
                Mobile Network Code (MNC): Vodafone GmbH (42)
          .00. .... = CHANNEL_NEEDED: 0
          ...0 .... = Exist_eMLPP_PRIORITY: 0
    
    Achieved by calling de_mid() on an octet-aligned buffer.
    
    Change-Id: Ia77e388f9ac18e4ecda27eeb3e04ce1bd978a3a5
    Reviewed-on: https://code.wireshark.org/review/35625
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  4d67f06   make-manuf.py: Add "of" to the general terms list.
     add  83fdea9   GSM RLC/MAC: dissect Mobile Identity in Packet Paging Request


Summary of changes:
 epan/dissectors/packet-gsm_rlcmac.c | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)