Wireshark-commits: [Wireshark-commits] master 11aef7c: BER: fix ber.error.bits_unknown display
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 02 Jan 2020 21:56:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=11aef7c19bd3e38ea288745d5f5bc76d1e6a6890
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

11aef7c by Pascal Quantin (pascal@xxxxxxxxxxxxx):

    BER: fix ber.error.bits_unknown display
    
    Before the changes done in v3.1.0rc0-431-gc2ac157ac0 and
    v3.1.0rc0-458-g37b91eedd6 the expert info was only displayed
    if at least 1 unknown bit was set to 1. Restore this behavior.
    
    Bug: 16301
    Change-Id: I3bea0992d6727154ef07d40ac18a7b012d3c1da4
    Reviewed-on: https://code.wireshark.org/review/35612
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  4f105e1   BGP: Support for drafts Tunnel Encapsulation and Segment Routing
     add  11aef7c   BER: fix ber.error.bits_unknown display


Summary of changes:
 epan/dissectors/packet-ber.c | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)