Wireshark-commits: [Wireshark-commits] master-3.2 1b8ed40: HTTP: Fix dissection of data following t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 Dec 2019 17:31:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b8ed4071e74c263778b50fa653df59f41df57ad
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

1b8ed40 by Peter Wu (peter@xxxxxxxxxxxxx):

    HTTP: Fix dissection of data following the HTTP Upgrade response
    
    When a HTTP response includes HTTP headers and a subset of data for the
    subdissector in the same frame, be sure to skip the HTTP headers for
    reassembly of the latter data. Otherwise the HTTP headers will be
    misinterpreted as the subprotocol (for example, WebSocket).
    
    Bug: 16274
    Change-Id: Ida6f6f2f7d0c463be2d498bfde5e8a9cd11a4b25
    Reviewed-on: https://code.wireshark.org/review/35536
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit e9014030fe2dc5926a7e7e8d9f29bf1ebcf6b6bd)
    Reviewed-on: https://code.wireshark.org/review/35614
    

Actions performed:

    from  a9335e1   Guides: Update some of the MaxMind text.
     add  1b8ed40   HTTP: Fix dissection of data following the HTTP Upgrade response


Summary of changes:
 epan/dissectors/packet-http.c | 7 +++++++
 1 file changed, 7 insertions(+)