Wireshark-commits: [Wireshark-commits] master aebe018: Cleanly fetch the query string.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 Dec 2019 10:14:11 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aebe01806169f5974c76b00d7408d56ea2e887a4
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

aebe018 by Guy Harris (guy@xxxxxxxxxxxx):

    Cleanly fetch the query string.
    
    Use tvb_get_string_enc(), because it guarantees null termination, unlike
    tvb_memdup(), and use ENC_ASCII|ENC_NA as the encoding, to convert
    non-ASCII characters to Unicode REPLACEMENT CHARACTER (there is *no*
    standard for the encoding of WHOIS texts other than "ASCII"; we use
    ENC_ASCII|ENC_NA elsewhere).
    
    Bug: 16298
    Change-Id: I6b7ff2a1af3997e8426ca07bea1ce68fe9cbc9c6
    Reviewed-on: https://code.wireshark.org/review/35564
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4010996   SMB2: display oplock/lease break packets properly
     add  aebe018   Cleanly fetch the query string.


Summary of changes:
 epan/dissectors/packet-whois.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)