Wireshark-commits: [Wireshark-commits] master-3.2 642a939: GSM A-bis/OML: fix: do not use tvb_get_n
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Dec 2019 05:22:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=642a939d0a2fea614dc77f85255680b5e26ce7ef
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

642a939 by Vadim Yanitskiy (axilirator@xxxxxxxxx):

    GSM A-bis/OML: fix: do not use tvb_get_ntohl() to fetch IPv4 address
    
    As per doc/README.dissector, the IPv4 addresses shall not be converted
    to host byte order before being passed to proto_tree_add_ipv4(). Due
    to this bug, the IPA Destination IP Address was displayed wrong.
    
    Change-Id: I2dd96590bbd736a8bfe05502d6803813838c6c59
    Bug: 16282
    Reviewed-on: https://code.wireshark.org/review/35501
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 88364fb2965e05c3eadb08a9b6a667c0a87313e3)
    Reviewed-on: https://code.wireshark.org/review/35515
    

Actions performed:

    from  cd79918   h264: fix label for frame_crop_right_offset
     add  642a939   GSM A-bis/OML: fix: do not use tvb_get_ntohl() to fetch IPv4 address


Summary of changes:
 epan/dissectors/packet-gsm_abis_oml.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)