Wireshark · Wireshark-commits: [Wireshark-commits] master d90a22c: Reorganize long option values

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d90a22c1cc3a6eaf739e9f4b40ea276dbc916d62
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d90a22c by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    Reorganize long option values
    
    For long options, without corresponding short options, to be processed
    they need to be assigned a value, preferably outside of the range of
    all possible short options. The code in various places tries to stay
    clear of these low values, but further coordination is missing, easily
    leading to issues when option processing code gets extended and/or
    reorganized.
    
    This change introduces a single location from where each catagory of
    command line long option can derive a base value, which should minimize
    potential option value collisions.
    
    Change-Id: Ic8861a347d0050f74002de3aa1fcfb01202866e5
    Reviewed-on: https://code.wireshark.org/review/35459
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  1cd1e36   extcap: remove potential leak.
     add  d90a22c   Reorganize long option values


Summary of changes:
 capture_opts.h            | 14 +++-----------
 editcap.c                 | 12 +++++++-----
 tshark.c                  | 11 ++++-------
 ui/cli/tap-exportobject.h |  2 --
 ui/clopts_common.h        | 16 ++++++++++++++++
 ui/commandline.c          | 11 +----------
 ui/dissect_opts.h         | 21 ++++-----------------
 7 files changed, 35 insertions(+), 52 deletions(-)