Wireshark-commits: [Wireshark-commits] master d884ff2: Qt: fix wrong checks.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Dec 2019 01:02:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d884ff2cdcd806ed5d7c97af3e895532ba7383be
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d884ff2 by Dario Lombardo (lomato@xxxxxxxxx):

    Qt: fix wrong checks.
    
    If actions_ is NULL, it will be dereferenced in the next check.
    Found by clang.
    
    Change-Id: I11f1620fae0e330dbbb7e0cc57b398f473261899
    Reviewed-on: https://code.wireshark.org/review/35373
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ef67401   Win32: Remove some unused code.
     add  d884ff2   Qt: fix wrong checks.


Summary of changes:
 ui/qt/widgets/capture_filter_edit.cpp | 2 +-
 ui/qt/widgets/display_filter_edit.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)