Wireshark-commits: [Wireshark-commits] master 7c883dd: Win32: Factor out win32_check_save_as_with_c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Dec 2019 00:59:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7c883dd771902887981c6253d01d33204d0d242e
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7c883dd by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Win32: Factor out win32_check_save_as_with_comments.
    
    Stop using win32_check_save_as_with_comments and just use the
    Qt equivalent on Windows. It started out as a static funtion in
    file_dlg_win32.c and using the native Windows event loop may have been
    required for GTK+, but neither of those apply now.
    
    Change-Id: I66d7f1c6346df65b0fadb3aa9cba823c0e457703
    Reviewed-on: https://code.wireshark.org/review/35382
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6a1ba1a   NGAP: catch NAS 5GS dissection errors
     add  7c883dd   Win32: Factor out win32_check_save_as_with_comments.


Summary of changes:
 ui/qt/capture_file_dialog.cpp | 24 +++++-------
 ui/win32/file_dlg_win32.c     | 89 -------------------------------------------
 ui/win32/file_dlg_win32.h     | 11 ------
 3 files changed, 9 insertions(+), 115 deletions(-)