Wireshark-commits: [Wireshark-commits] master 6925671: RPC-over-RDMA: add reassembly of SEND first,
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 09 Dec 2019 05:11:22 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6925671887b25f875aa81e7f474369db351f71ff
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6925671 by Jorge Mora (jmora1300@xxxxxxxxx):

    RPC-over-RDMA: add reassembly of SEND first, middle and last
    
    Linux uses SEND first, middle and last for small NFS reads
    instead of using the write chunk list. Reassembly is done
    using the PSN (packet sequence number) to order the segments
    in case one or more segments are sent out of order.
    Reassembly uses a single message id per each direction of a
    given conversation so it is tied to the destination queue
    pair. Also, the PSN given in the SEND First packet is used
    as a base so fragment numbers are relative and start at zero.
    Furthermore, a previous incomplete reassembly is thrown away
    in the SEND First packet so any fragments previously added
    to the reassembly table are not included in the current
    reassembled message.
    
    Bug: 16225
    Change-Id: I8de6a3123676e348d8e893f0f67d4b3ba38db27f
    Reviewed-on: https://code.wireshark.org/review/35224
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f5705e9   WSUG: Export, packet range+format, and other IO chapter updates.
     add  6925671   RPC-over-RDMA: add reassembly of SEND first, middle and last


Summary of changes:
 epan/dissectors/packet-rpcrdma.c | 89 ++++++++++++++++++++++++++++++++++++++--
 1 file changed, 86 insertions(+), 3 deletions(-)