Wireshark-commits: [Wireshark-commits] master 8275036: Make the TTL field unsigned, but keep warnin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 07 Dec 2019 23:22:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8275036fda8a7a5b9d0819c0ea3e3e26ad6e45ec
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8275036 by Guy Harris (guy@xxxxxxxxxxxx):

    Make the TTL field unsigned, but keep warning if the high-order bit is set.
    
    See RFC 2181, section 8 (and RFC 1035 erratum 2130, which notes that
    section 3.2.1 says the TTL is signed but section 4.1.3 says it's
    unsigned); RFC 2181 section 8 says "unsigned, but avoid sending values
    that have the uppermost bit set, and treat values with the uppermost bit
    set as a value of 0".  (STD 13 = RFC 1034, the "concepts and facilities"
    DNS RFC, plus RFC 1035, the "implementation and specification" DNS RFC.)
    
    Change-Id: I9be6ac4f190f62dafbc45d1923a95f8f21306a7d
    Reviewed-on: https://code.wireshark.org/review/35343
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1e3db49   recent.c: cfield might be NULL
     add  8275036   Make the TTL field unsigned, but keep warning if the high-order bit is set.


Summary of changes:
 epan/dissectors/packet-dns.c | 50 ++++++++++++++++++++++++++++++++++++++------
 1 file changed, 44 insertions(+), 6 deletions(-)