Wireshark-commits: [Wireshark-commits] master 54010d4: Add support for first frames with CAN-FD
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 29 Nov 2019 08:39:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=54010d4093fc86011c17ff091cccd39b391a2e20
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

54010d4 by Stefan Tatschner (stefan@xxxxxxxxxxxxxx):

    Add support for first frames with CAN-FD
    
    In the case CAN-FD is used as a transport, the header of ISO15765
    changes for first frames (ISO 15765-2:2015). This patch uses the
    introduced `struct can_info` to access the relevant metadata of the
    underlying CAN frame. Dissection is chosen accordingly.
    
    Ressources:
    
    * https://www.can-cia.org/fileadmin/resources/documents/proceedings/2015_hartkopp.pdf
    * http://s3.eu-central-1.amazonaws.com/cancia-de/documents/proceedings/slides/hartkopp_slides_15icc.pdf
    * https://github.com/linux-can/can-utils/commit/8150e21a1129c4b822d73186cd63e0e9fbf4c32d
    
    Change-Id: I248acacab62b51659efaed400b828ac0bb9e3c55
    Reviewed-on: https://code.wireshark.org/review/35247
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  50595de   RTCP:MCPTT fix while loop and location info.
     add  54010d4   Add support for first frames with CAN-FD


Summary of changes:
 epan/dissectors/packet-iso15765.c | 46 ++++++++++++++++++++++++---------------
 1 file changed, 29 insertions(+), 17 deletions(-)