Wireshark-commits: [Wireshark-commits] master f2dce23: Qt+macOS: Add /Volumes to the file dialog si
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 26 Nov 2019 05:37:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f2dce23b408e277d5a2a243516fa267fe756ba53
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f2dce23 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt+macOS: Add /Volumes to the file dialog sidebar.
    
    /Volumes is hidden on macOS, which means that it doesn't show up in Qt's
    non-native file dialog. Add a constructor to WiresharkFileDialog that
    adds /Volumes to the file dialog sidebar. Make CaptureFileDialog and
    ExportDissectionDialog subclasses of WiresharkFileDialog.
    
    Bug: 13840
    Change-Id: I4d7da3948b203eb11fb64fa056eb42a448edf914
    Reviewed-on: https://code.wireshark.org/review/35201
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  6920118   WireGuard: support Decode As and non-zero reserved bytes
     add  f2dce23   Qt+macOS: Add /Volumes to the file dialog sidebar.


Summary of changes:
 ui/qt/capture_file_dialog.cpp           | 12 ++++++------
 ui/qt/capture_file_dialog.h             |  5 +++--
 ui/qt/export_dissection_dialog.cpp      |  4 ++--
 ui/qt/export_dissection_dialog.h        |  4 ++--
 ui/qt/widgets/wireshark_file_dialog.cpp | 26 ++++++++++++++++++++++++++
 ui/qt/widgets/wireshark_file_dialog.h   |  1 +
 6 files changed, 40 insertions(+), 12 deletions(-)