Wireshark-commits: [Wireshark-commits] master 8f90446: Qt: Refactor ExportObjectsDialog
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 22 Nov 2019 05:10:25 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f90446db55c342b28d2dc8f1ab5f01b366b6993
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8f90446 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Refactor ExportObjectsDialog
    
    Add the following features:
    
    - search now operates live (enter text changes the list live)
    - filter by content-types
    - Preview certain content types directly from the dialog
    
    Change-Id: If47b64d475dd3e77485a28e8443a3e139e9bd1a4
    Reviewed-on: https://code.wireshark.org/review/35182
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  06afefa   QUIC: atag is an array of bytes, not pointers
     add  8f90446   Qt: Refactor ExportObjectsDialog


Summary of changes:
 ui/qt/export_object_dialog.cpp        | 114 ++++++++++++++++++++++++++++------
 ui/qt/export_object_dialog.h          |  19 ++++--
 ui/qt/export_object_dialog.ui         |  55 +++++++++-------
 ui/qt/main_window_slots.cpp           |   7 +--
 ui/qt/models/export_objects_model.cpp |  40 ++++++++++++
 ui/qt/models/export_objects_model.h   |   9 +++
 ui/qt/widgets/export_objects_view.cpp |   6 +-
 ui/qt/widgets/export_objects_view.h   |   2 +-
 8 files changed, 197 insertions(+), 55 deletions(-)