Wireshark-commits: [Wireshark-commits] master 06afefa: QUIC: atag is an array of bytes, not pointer
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 22 Nov 2019 05:08:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=06afefad91804f33c4c825764cb045bb50c3842c
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

06afefa by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: atag is an array of bytes, not pointers
    
    The allocated buffer is unnecessarily large due to the array storing
    pointers instead of bytes. This wastes memory but has no other bad
    side-effects. It was not caught by the compiler because the users accept
    void pointers. I only noticed it in the debugger.
    
    Change-Id: I9690b5481289d17fed34512b6a32915c3a30d36b
    Reviewed-on: https://code.wireshark.org/review/35184
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b22a63d   docs: fix up MS toolchain references
     add  06afefa   QUIC: atag is an array of bytes, not pointers


Summary of changes:
 epan/dissectors/packet-quic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)