Wireshark · Wireshark-commits: [Wireshark-commits] master 141e2ff: Note that Qt imposes a maximum frame number of 2^31-1.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=141e2ffcf03640bf270b37a08d6a265685cf7563
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

141e2ff by Guy Harris (guy@xxxxxxxxxxxx):

    Note that Qt imposes a maximum frame number of 2^31-1.
    
    Nothing in libwireshark limits frame numbers to 2^31-1 - they're stored
    as unsigned ints and thus can go up to 2^32-1.  That doesn't fit with
    the way QTreeView works, as the model is ultimately from a subclass of
    QAbstractItemModel, and that uses ints, not unsigned ints, for row
    numbers.
    
    Change-Id: I174c3ccdb5e86ea5897643560936c301fcc78c54
    Reviewed-on: https://code.wireshark.org/review/35141
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  fc18fbd   Raise a question in a comment.
     add  141e2ff   Note that Qt imposes a maximum frame number of 2^31-1.


Summary of changes:
 ui/qt/packet_list.h | 7 +++++++
 1 file changed, 7 insertions(+)