Wireshark-commits: [Wireshark-commits] master 1078904: Qt: Remove unnecessary parent check
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 19 Nov 2019 12:08:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=10789049817eba945c748dafa3cf8440e40f57f0
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1078904 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Remove unnecessary parent check
    
    parent.column() will allways be -1, due to ::parent returning
    QModelIndex() and therefore parent being invalid all the time.
    
    Change-Id: Ibb0482b4204523dba71a2be4f078da4f11fcaf71
    Reviewed-on: https://code.wireshark.org/review/35134
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  effbcdc   Qt: Remove unused progress update
     add  1078904   Qt: Remove unnecessary parent check


Summary of changes:
 ui/qt/models/packet_list_model.cpp | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)