Wireshark-commits: [Wireshark-commits] master b3f240d: Qt: Multiselection in PacketList
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Nov 2019 12:20:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b3f240dbf8c5e24cf420e977d8544c4abb40c80e
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b3f240d by Roland Knall (rknall@xxxxxxxxx):

    Qt: Multiselection in PacketList
    
    This implements multi-selection for the PacketList. It
    allows multiple lines to be selected, and either drag/drop
    them to a text editor or use Ctrl/Cmd+C to copy the content
    to a clipboard.
    
    Opening the context menu disables the selection, and it
    does not change the underlying currently selection. This is
    done on purpose, as multi-selection is a copy-task only
    functionality at this point
    
    Export & Print work as expected, exporting just the selected
    items. Same goes for the copy menu, which has the additional
    entries for copying the list elements
    
    Bug: 14612
    Change-Id: I77960aa1ab1d172a21abfa469baac0cd57f9f9d9
    Reviewed-on: https://code.wireshark.org/review/35073
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  7d2e3fa   [Automatic update for 2019-11-17]
     add  b3f240d   Qt: Multiselection in PacketList


Summary of changes:
 ui/packet_range.c                        |  88 +++++++++---
 ui/packet_range.h                        |  10 +-
 ui/qt/capture_file_dialog.cpp            |  15 +-
 ui/qt/capture_file_dialog.h              |   4 +-
 ui/qt/export_dissection_dialog.cpp       |   4 +-
 ui/qt/export_dissection_dialog.h         |   2 +-
 ui/qt/main_status_bar.cpp                |  20 ++-
 ui/qt/main_window.cpp                    |  52 +++++--
 ui/qt/main_window.h                      |  14 +-
 ui/qt/main_window.ui                     |  30 +++-
 ui/qt/main_window_slots.cpp              | 119 +++++++++++++---
 ui/qt/models/packet_list_model.cpp       |  66 ++++++---
 ui/qt/models/packet_list_model.h         |   4 +-
 ui/qt/models/related_packet_delegate.cpp |  26 +++-
 ui/qt/packet_list.cpp                    | 237 ++++++++++++++++++++++++++-----
 ui/qt/packet_list.h                      |  16 +++
 ui/qt/packet_range_group_box.cpp         |  22 +--
 ui/qt/packet_range_group_box.h           |   2 +-
 ui/qt/print_dialog.cpp                   |   6 +-
 ui/qt/print_dialog.h                     |   9 +-
 ui/qt/proto_tree.cpp                     |  19 +++
 ui/qt/proto_tree.h                       |   2 +
 ui/qt/wireshark_en.ts                    |  20 ++-
 ui/win32/file_dlg_win32.c                |  22 ++-
 24 files changed, 639 insertions(+), 170 deletions(-)