Wireshark-commits: [Wireshark-commits] master 0205720: macOS: Add support for automatic updates usi
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 15 Nov 2019 18:39:11 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=02057200fd73fc70cc4a6eeece5c033c14f0c50a
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

0205720 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    macOS: Add support for automatic updates using Sparkle.
    
    Add support for automatic updates using the Sparkle framework. Add
    FindSparkle.cmake and associated CMake plumbing. Add a public key and
    other info to Info.plist.in. Add ui/macosx/sparkle_bridge.{h,m}, which
    wraps the Sparkle API. Make code that's specific to WinSparkle
    Windows-only.
    
    Add Sparkle installation steps to the macos-setup scripts. Sparkle
    prints a warning if your bundle is unsigned (which is the case during
    development) so disable installing it by default.
    
    Updating here takes a long time. We might be able to fix that by
    shipping our DSYMs separately.
    
    Change-Id: I6cc6671db5657dadc514bda6bf6e1c8bbc9468a5
    Reviewed-on: https://code.wireshark.org/review/35090
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  fd4bb1e   GTPv2: fix wrong offset in FWRDRELREQ if Target Type is gNB ID
     add  0205720   macOS: Add support for automatic updates using Sparkle.


Summary of changes:
 CMakeLists.txt                                 |  7 +++
 CMakeOptions.txt                               |  3 +-
 cmake/modules/FindSparkle.cmake                | 22 ++++++++
 cmakeconfig.h.in                               |  2 +-
 docbook/release-notes.adoc                     |  1 +
 packaging/macosx/Info.plist.in                 | 17 ++++++
 packaging/macosx/osx-app.sh.in                 |  6 +++
 tools/macos-setup-brew.sh                      |  3 ++
 tools/macos-setup.sh                           | 44 ++++++++++++++++
 ui/macosx/{cocoa_bridge.h => sparkle_bridge.h} | 23 ++++----
 ui/macosx/sparkle_bridge.m                     | 44 ++++++++++++++++
 ui/qt/main_window.cpp                          |  2 +-
 ui/qt/main_window.h                            |  2 +-
 ui/qt/main_window_slots.cpp                    |  2 +-
 ui/qt/wireshark_application.cpp                |  8 +--
 ui/qt/wireshark_application.h                  |  6 +--
 ui/software_update.c                           | 73 ++++++++++++++++----------
 ui/software_update.h                           | 10 ++++
 18 files changed, 224 insertions(+), 51 deletions(-)
 create mode 100644 cmake/modules/FindSparkle.cmake
 copy ui/macosx/{cocoa_bridge.h => sparkle_bridge.h} (50%)
 create mode 100644 ui/macosx/sparkle_bridge.m