Wireshark-commits: [Wireshark-commits] master 5f8ed11: Qt: Fix various LGTM.com reported issues
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 Nov 2019 22:54:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f8ed1126a812b49ec5f6728739892c21d0fb3ec
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5f8ed11 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Fix various LGTM.com reported issues
    
    Mostly shadowed variables or similar minor issues
    
    Change-Id: I98a76eb4cac1ba1356a239a0ed7beb550ced0651
    Reviewed-on: https://code.wireshark.org/review/35091
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  725200d   GTP: improve LTE/NR PDCP container configuration
     add  5f8ed11   Qt: Fix various LGTM.com reported issues


Summary of changes:
 ui/qt/models/astringlist_list_model.cpp |  6 +++---
 ui/qt/models/coloring_rules_model.cpp   | 14 ++++++++++++--
 ui/qt/models/coloring_rules_model.h     |  3 +++
 ui/qt/models/credentials_model.h        |  5 +++++
 ui/qt/models/filter_list_model.cpp      |  4 ++--
 ui/qt/models/packet_list_model.h        |  3 +--
 6 files changed, 26 insertions(+), 9 deletions(-)