Wireshark-commits: [Wireshark-commits] master 90e4da6: ZigBee: Add APS conversations and extended c
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 Nov 2019 09:21:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=90e4da60bc2ba78a5740c19641c07aaa6fc5874c
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

90e4da6 by Kenneth Soerensen (knnthsrnsn@xxxxxxxxx):

    ZigBee: Add APS conversations and extended counter
    
    The APS counter is only 8-bit, which causes trouble for the
    reassembly of fragments because packet counters are reused.
    
    With this change the counter is extended to 32-bit to avoid
    packet counter clashes.
    
    Inspiration is taken from the RTP dissector.
    
    Bug: 15021
    Change-Id: Ibc61f40dd12b7a1bfd69b24ed5200d31229b69cb
    Reviewed-on: https://code.wireshark.org/review/35072
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a924de1   test/suite_decryption: Add WPA3 SuiteB-192 bit test
     add  90e4da6   ZigBee: Add APS conversations and extended counter


Summary of changes:
 epan/dissectors/packet-zbee-aps.c | 83 +++++++++++++++++++++++++++++++++------
 epan/dissectors/packet-zbee-aps.h | 25 ++++++++++++
 2 files changed, 97 insertions(+), 11 deletions(-)