Wireshark · Wireshark-commits: [Wireshark-commits] master 820e1c9: dot11decrypt: Export Dot11DecryptDecryptKeyData function

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=820e1c9bee9fd4cd2471fa15721d489e7e1d3202
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

820e1c9 by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    dot11decrypt: Export Dot11DecryptDecryptKeyData function
    
    Simplify the still quite complex Dot11DecryptScanEapolForKeys function
    and further reduce frame parsing inside Dot11Decrypt engine. This is
    done by breaking out the EAPOL keydata decryption step into a new
    function Dot11DecryptDecryptKeyData to be called from dissector.
    
    After this Dot11DecryptScanEapolForKeys can now focus on one
    task, to scan for keys in (unencrypted) EAPOL key frames.
    
    With keydata decryption step separated from the broadcast
    key parsing step the dissectors' GTK parsing can replace
    the Dot11Decrypt internal RSN GTK TAG parsing.
    
    Change-Id: I3b89f40586b8b7dbe2ff74cfc30761010d5b80bc
    Reviewed-on: https://code.wireshark.org/review/35022
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4222603   dot11decrypt: Introduce Dot11DecryptGroupHandshake function
     add  820e1c9   dot11decrypt: Export Dot11DecryptDecryptKeyData function


Summary of changes:
 epan/crypt/dot11decrypt.c          | 213 ++++++++++++++-----------------------
 epan/crypt/dot11decrypt_system.h   |  52 ++++++---
 epan/dissectors/packet-ieee80211.c | 150 +++++++++++++++++---------
 3 files changed, 219 insertions(+), 196 deletions(-)