Wireshark · Wireshark-commits: [Wireshark-commits] master 2ff91fa: TCP: increment nextseq for FIN and SYN packets

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ff91faf896e24186fa59b462856943500d2d60a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2ff91fa by Uli Heilmeier (uh@xxxxxxxxxxxx):

    TCP: increment nextseq for FIN and SYN packets
    
    For TCP SYN and FIN flags sequence/acknowledgment number increments
    by one. Therefore we should also increment the nextseq field.
    
    With this commit we increment nextseq regardless of TCP data.
    So far we did this only when there was TCP payload included (e.g. with
    TCP Fast Open).
    
    We do this direct for the hf field as the variable nxtseq is also used
    for TCP sequence analysis and to dissect the TCP payload.
    
    The in flights bytes are now correctly calculated when SYN or FIN bit
    is set.
    
    Furthermore this commit allows reassemble of segmented TCP payload also
    with SYN bit set. This works also when payload overlaps (without option
    analyzing sequence number enabled. Otherwise it is detected as
    retransmission.).
    
    Bug: 15964
    Bug: 9882
    Change-Id: I0b12f9ec9803e9367d4a8f9a6ceac759f7d56cbd
    Reviewed-on: https://code.wireshark.org/review/34273
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  766f231   Release notes: Add an item about following HTTP/2 and QUIC.
     add  2ff91fa   TCP: increment nextseq for FIN and SYN packets


Summary of changes:
 epan/dissectors/packet-tcp.c | 39 +++++++++++++++++++++++++--------------
 1 file changed, 25 insertions(+), 14 deletions(-)