Wireshark-commits: [Wireshark-commits] master 3c8c392: Qt: Cleanup push/pop Infos
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 Nov 2019 22:03:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3c8c392b9d6001bd5fadca887caf69bdf7ec74ad
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3c8c392 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Cleanup push/pop Infos
    
    Currently push pop is propagated by a massive load of signals
    which partly are also propagated through parent objects.
    
    This moves the status handling to WiresharkApplication, also
    pathlining future moves to move status to different classes or
    use additional methods of status information
    
    Change-Id: Ibcb2c98688f1adf40dce1483f336596ef992bb06
    Reviewed-on: https://code.wireshark.org/review/35071
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  ba62446   cppcheck: Re-ignore asn1.
     add  3c8c392   Qt: Cleanup push/pop Infos


Summary of changes:
 ui/qt/address_editor_frame.cpp         |   3 +-
 ui/qt/address_editor_frame.h           |   1 -
 ui/qt/column_editor_frame.cpp          |   7 +-
 ui/qt/column_editor_frame.h            |   1 -
 ui/qt/filter_expression_frame.cpp      |   7 +-
 ui/qt/filter_expression_frame.h        |   1 -
 ui/qt/main_status_bar.cpp              | 134 +++++++++------------------------
 ui/qt/main_status_bar.h                |  32 ++++----
 ui/qt/main_window.cpp                  |  18 +----
 ui/qt/main_window.h                    |   3 +
 ui/qt/main_window_slots.cpp            |  40 +++++-----
 ui/qt/preference_editor_frame.cpp      |   2 +-
 ui/qt/preference_editor_frame.h        |   1 -
 ui/qt/search_frame.cpp                 |  26 +++----
 ui/qt/search_frame.h                   |   3 -
 ui/qt/welcome_page.cpp                 |   4 -
 ui/qt/welcome_page.h                   |   2 -
 ui/qt/widgets/capture_filter_combo.cpp |   4 -
 ui/qt/widgets/capture_filter_combo.h   |   2 -
 ui/qt/widgets/capture_filter_edit.cpp  |   4 +-
 ui/qt/widgets/capture_filter_edit.h    |   2 -
 ui/qt/widgets/display_filter_edit.cpp  |  16 ++--
 ui/qt/wireless_frame.cpp               |  15 ++--
 ui/qt/wireless_frame.h                 |   1 -
 ui/qt/wireshark_application.cpp        |  71 +++++++++++++++++
 ui/qt/wireshark_application.h          |  12 +++
 26 files changed, 197 insertions(+), 215 deletions(-)