Wireshark-commits: [Wireshark-commits] master 7a1a45c: Qt: Signal empty display filter bar
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 Nov 2019 13:56:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7a1a45c5234e64286452863088bb9552922b2b3c
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7a1a45c by Roland Knall (rknall@xxxxxxxxx):

    Qt: Signal empty display filter bar
    
    If a display filter is applied, but the display filter bar
    has been cleared by deleting the context (either by setting a
    space or backspacing over the filter), it is not clearly indicated
    that the filter is still being applied.
    
    Bug: 12438
    Change-Id: Ibd4c48b094467182ed51e9859e0d5fad770000c7
    Reviewed-on: https://code.wireshark.org/review/35070
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  75a4be6   Reassemble: Fix typo
     add  7a1a45c   Qt: Signal empty display filter bar


Summary of changes:
 ui/qt/widgets/display_filter_edit.cpp | 18 ++++++++++++++----
 ui/qt/widgets/display_filter_edit.h   |  1 +
 2 files changed, 15 insertions(+), 4 deletions(-)