Wireshark-commits: [Wireshark-commits] master ccc88ba: Revert "ieee80211: fix dissection of HE Phy
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 Nov 2019 08:40:31 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ccc88bad93a6ca55741a14f33ed2d3015652454f
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ccc88ba by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    Revert "ieee80211: fix dissection of HE Phy Capabilities Information"
    
    This reverts commit 39bbb90e783e8ab6b5bc435927e8f05ec809194e.
    
    If you check 9.4.2.242.3 HE PHY Capabilities Information field, you will see the "Supported Channel Width" field starts from B1 of the "HE PHY Capabilities Information field", not B0.
    The Table  9-231 Subfields of the HE PHY Capabilities Information fiel applies only for the Channel Width Support Field. So B1 of the PHY cap should be used as B0 of the channel width.
    
    Bug: 16190
    Change-Id: Iff5beaf93f57d535b70ffab4b51e4a163aaf3a6d
    Reviewed-on: https://code.wireshark.org/review/35038
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d88d88a   SMB2: Add @timestamp to the info column if we see a timewarp ECP.
     add  ccc88ba   Revert "ieee80211: fix dissection of HE Phy Capabilities Information"


Summary of changes:
 epan/dissectors/packet-ieee80211.c | 37 ++++++++++++++++++++++++++++---------
 1 file changed, 28 insertions(+), 9 deletions(-)