Wireshark-commits: [Wireshark-commits] master-2.6 c45fdab: Fix display of pino protocols in display
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 Nov 2019 08:24:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c45fdab18b63fbdd35f59c12f9bf3f2f5359dc0e
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

c45fdab by Pascal Quantin (pascal@xxxxxxxxxxxxx):

    Fix display of pino protocols in display filter dropdown
    
    Qt GUI uses proto_get_first_protocol() to find the list of protocols
    and build the autocompletion list. As pinfo protocols are stored in
    another list, they are kept aside.
    Let's add them in the same list as normal protocols.
    
    Bug: 16130
    Change-Id: I9ff67ea4198a8cc6baf3ded584c48eadfb097092
    Reviewed-on: https://code.wireshark.org/review/34778
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/35060
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  c83d2ad   Don't report EPIPE errors writing out packet information.
     add  c45fdab   Fix display of pino protocols in display filter dropdown


Summary of changes:
 epan/proto.c | 26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)