Wireshark-commits: [Wireshark-commits] master c4e41e3: Qt: Make clearing display filter behave more
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 10 Nov 2019 23:34:22 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c4e41e356a4f269df5d549a0cd6ac90d3a16da5e
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c4e41e3 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Make clearing display filter behave more logical
    
    If the display filter is cleared, because it is emptied, the
    new display filter ("") is not yet applied. This is not signaled
    properly, as the user get's the expression, that no filter is applied,
    although the old one still is. Visible is this by displaying
    the placeholder text and removing the clear button
    
    With this patch, in such a case, the placeholder text is empty
    and the clear button still visible, until really an empty filter
    is being applied.
    
    Bug: 12438
    Change-Id: I45128ebf2bc1854da5a4055d3980d913d0139a28
    Reviewed-on: https://code.wireshark.org/review/35045
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  bb2bf1c   BMP: Add support of draft-ietf-grow-bmp-local-rib-06
     add  c4e41e3   Qt: Make clearing display filter behave more logical


Summary of changes:
 ui/qt/widgets/display_filter_edit.cpp | 19 ++++++++++++++++++-
 ui/qt/widgets/display_filter_edit.h   |  1 +
 2 files changed, 19 insertions(+), 1 deletion(-)