Wireshark-commits: [Wireshark-commits] master 71996e8: CMake+docbook: Fixup our .chm titles.
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 08 Nov 2019 20:27:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=71996e8d93b82ad25105f691d001188b5972d922
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

71996e8 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    CMake+docbook: Fixup our .chm titles.
    
    Some parts of HTML Help have issues displaying curly quotes. Add a
    title argument to the XML2HHP macro so that we can set one with a
    straight quote. Set the title using the htmlhelp.title XSL parameter
    instead of relying on HTML Help to derive it for us. This seems to keep
    "???TITLE???" from being mysteriously appended to the title.
    
    Try setting htmlhelp.window.geometry while we're here.
    
    Bug: 16183
    Change-Id: I0bf2dbeeb811dc65010ab5223725d6b5cdc96966
    Reviewed-on: https://code.wireshark.org/review/35031
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  bf5d699   travis: bump xcode versions.
     add  71996e8   CMake+docbook: Fixup our .chm titles.


Summary of changes:
 cmake/modules/FindXSLTPROC.cmake | 14 +++++++-------
 docbook/CMakeLists.txt           |  4 ++--
 docbook/custom_layer_chm.xsl     |  6 +-----
 3 files changed, 10 insertions(+), 14 deletions(-)