Wireshark-commits: [Wireshark-commits] master f9c2451: Kerberos: rework dissecting for PA-PW-SALT
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 08 Nov 2019 07:36:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f9c24510fa3020ca3c976fd0cb8bd6ea71cb5ad6
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f9c2451 by Uli Heilmeier (uh@xxxxxxxxxxxx):

    Kerberos: rework dissecting for PA-PW-SALT
    
    PA-PW-SALT is not defined according to RFC 4120 sec 5.2.7.3.
    Therefore we should not expect that this is a Microsoft implementation
    where we also only know the first 4 bytes. Furthermore not all values
    of nt_status which appears in wild are defined.
    
    Bug: 6234
    Change-Id: I870070cfacfe63ef03d67c234bba88b8b5cf3608
    Reviewed-on: https://code.wireshark.org/review/35028
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e023908   SNMP: do not modify the ASN.1 source for request/response tracking
     add  f9c2451   Kerberos: rework dissecting for PA-PW-SALT


Summary of changes:
 .../asn1/kerberos/packet-kerberos-template.c       | 38 ++++------------
 epan/dissectors/packet-kerberos.c                  | 50 +++++++---------------
 2 files changed, 24 insertions(+), 64 deletions(-)